patch(typegen): stops defaultMaximumTruncationLength getter error
#47
Conversation
src/typegen.ts
Outdated
| if (!/^5\.\d$/.test(ts.versionMajorMinor)) { | ||
| (ts as any).defaultMaximumTruncationLength = Infinity | ||
| } |
There was a problem hiding this comment.
This makes sense and thank for the fix! Though now I wonder what'll happen when TS 6 comes out. It'll likely work the same way as 5. Thus it might be better here to check that parseInt(ts.versionMajorMinor.split('.')[0]) < 5 or something like that?
There was a problem hiding this comment.
That makes sense - fixed it!
Have you had any kind of conversation with the TypeScript team about what they consider to be the proper way to do what this code is trying to do? You can't be the only person parsing TypeScript ASTs and running into this problem...
There was a problem hiding this comment.
Thanks! v3.3.3 is out with the fix.
And no, I haven't had any contact with the TS team. Things are mostly stable and working, until some TS upgrade changes things again. 🤷
This PR prevents the error mentioned in #44 from occurring for TypeScript versions >= 5. I don't know that it's actually solving the underlying problem that modifying
defaultMaximumTruncationLengthwas attempting to solve in the latest versions. According to this long-standing issue, it sounds like there hasn't ever been a way to actually modify this value, although that could just be referring to the public configuration options.I'm more than happy to modify this, but it feels like patching the functionality is likely the most valuable path to move forward quickly rather than trying to identify the "right" way to do this.
Closes #44