Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Improvements #110

Merged
merged 5 commits into from
Jun 19, 2022
Merged

Code Improvements #110

merged 5 commits into from
Jun 19, 2022

Conversation

DEADSEC-SECURITY
Copy link
Collaborator

All of the following changes where tested on my Alexa and Home Assistant version 2022.6.1

Changes:

  • Added possibility to not send a entity_id in state and it will not wait for reponse only speak.
    (This information needs to be added to the wiki)
    (Also would be cool to add a new script in HA for Speak only)
  • Improved logging, adding more debug information
  • Added easy DEBUG on/off
  • Linted code with pylint
  • General code improvements with f-strings and get methods for readability

Fixed:

  • Fixed logging messages not being printed to cloudwatch

@keatontaylor keatontaylor merged commit 13222b1 into keatontaylor:master Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keatontaylor keatontaylor keatontaylor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DEADSEC-SECURITY @keatontaylor