Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setting to indicate on the Playboard when 'Show Errors' is enabled. #152

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

runs-with-scissors
Copy link

When the "Show Errors Indicator" setting is checked, and "Show Errors" is enabled, the color of each box's borderline is the 'errorColor'

… color of each box's borderline the 'errorColor'
@runs-with-scissors
Copy link
Author

Screenshots

screenshot_20190121-013440
screenshot_20190121-013500
screenshot_20190121-013507

@runs-with-scissors runs-with-scissors changed the title Added setting to indicate when 'Show Errors' is enabled. Added setting to indicate on the Playboard when 'Show Errors' is enabled. Jan 21, 2019
@gaul
Copy link
Contributor

gaul commented Jan 21, 2019

I dislike these jarring colors -- could we display a status icon next to the ellipses when the user has a wide screen like a tablet instead?

@runs-with-scissors
Copy link
Author

@gaul wrote:

#152 (comment): I dislike these jarring colors -- could we display a status icon next to the ellipses when the user has a wide screen like a tablet instead?

Very good point. I now see how the colors would become distracting/annoying after a while. I think it makes sense to use a status icon for all devices, not just tablets.

Here are a few icons available from the Asset Studio which could work. I think the spellcheck icon would be a good fit for our use case (more optimistic than an error-related icon 😉)

image

@gaul
Copy link
Contributor

gaul commented Jan 22, 2019

Sounds good for tablets although phones have a limited space for the clue.

@runs-with-scissors
Copy link
Author

Instead of adding a status icon, I decided to make it so that the change only applies to the currently selected word and not the whole grid. The red borderline wasn't noticeable enough in day mode, so I changed it to blue and increased its thickness
screenshot_20190209-163815-min2
screenshot_20190209-163831-min2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants