-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional language GER => 'de' #18
Additional language GER => 'de' #18
Conversation
I added up the German translations for the given commands as a means to use your code in my lessons :D Greetings from Germany and thanks for your awesome project! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DiWoWet
Vielen dank für die Übersetzung!
There is one place I would like you to check. I think everything else is fine and I can merge it as soon as I receive your reply.
}, | ||
flip: { | ||
'ja': '[DIRECTION]に宙返りする', | ||
'ja-Hira': '[DIRECTION]にちゅうがえりする', | ||
'en': 'flip in [DIRECTION]', | ||
'fr': 'flip vers [DIRECTION]' | ||
'fr': 'flip vers [DIRECTION]', | ||
'de': 'Flip nach [DIRECTION]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the first letter is lowercase?
(If "Flip" is used as a noun and is capitalized, ignore my review.)
'de': 'Flip nach [DIRECTION]' | |
'de': 'flip nach [DIRECTION]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really use it as a noun in this context. I also thought of "Drehung" but this rather means a circular movement on the x-axis and would thus be the wrong translation. Thanks for checking it after such a short time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. Now, I'm going to merge.
Within a few days I will release new binaries including German translation. Until then, please be patient. |
@DiWoWet Hi, Today I released v1.3.1 that including German translation! And I added the credit for translation in README. Thanks for your contribution! |
Thanks for your project. I will try to help as much as I can with my class as we're going to build upon your work in an educational stem environment. Thank you so much and keep up the great work👍👍👍 |
It is my true desire that this project will benefit education. A project is only effective when it is used. Thank you very much! |
I added up the German translations for the given commands as a means to use your code in my lessons :D Greetings from Germany and thanks for your awesome project! :)