Generate SQL templates #1
Conversation
martinjunger
force-pushed
the
mj-generate-sql-templates
branch
from
268ed84 to
d4aba15
Compare
martinjunger
force-pushed
the
mj-generate-sql-templates
branch
from
a49f40a to
e9bbd8a
Compare
martinjunger
requested review from
a team,
romanbracinik,
tomasfejfar and
zajca
and removed request for
a team and
romanbracinik
martinjunger
force-pushed
the
mj-generate-sql-templates
branch
from
913ae1d to
c1fb666
Compare
| @@ -1,4 +1,4 @@ | |||
| FROM php:8-cli | |||
| FROM php:7.4-cli | |||
There was a problem hiding this comment.
proč 7.4 jestli kvůli csv-options tak bysme měli vydat novů verzi nebo by šlo ignorovat ten requirement
There was a problem hiding this comment.
Zatim to nejspis nepujde... Je tam totiz zavislost:
php-db-import-export- php8 readyphp-csv-options- php8 readyphp-csv-db-import-^7.1phpunit/dbunit-^7.1+ no longer maintained
Muzeme to forknout a upravit (nejaky takovy forky uz jsou)...
tests/functional/ComponentTest.php
Outdated
| self::assertStringStartsWith( | ||
| "IF OBJECT_ID (N'{{ id(destSchemaName) }}.{{ id(stageTableName ~ '_tmp') }}', N'U') " . | ||
| "IS NOT NULL DROP TABLE {{ id(destSchemaName) }}.{{ id(stageTableName ~ '_tmp') }}", | ||
| $queries[6]['sql'] | ||
| ); | ||
| self::assertStringStartsWith( | ||
| "IF OBJECT_ID (N'{{ id(destSchemaName) }}.{{ id(stageTableName ~ '_tmp_rename') }}', N'U') IS NOT NULL " . | ||
| "DROP TABLE {{ id(destSchemaName) }}.{{ id(stageTableName ~ '_tmp_rename') }}", | ||
| $queries[7]['sql'] | ||
| ); |
There was a problem hiding this comment.
to budem muset ještě nějak pořešit protože toto je ve finally
| <<<SQL | ||
| COPY INTO [stageSchemaName634ff46baec71046847136].[__temp_stageTableName634ff46baec72821993597] | ||
| FROM 'sourceFile1634ff46baec6c521446965' | ||
| WITH ( CREDENTIAL=(IDENTITY='Shared Access Signature', SECRET={{ '?' ~ sourceSasSecret }}) ) |
There was a problem hiding this comment.
nejsu si jistý jestli ten name parametr bude fungovat takto, doctrine na to má :param s dvojtečků. A řekl bych, že SQL server používá @param syntax. Možná bych použil nepojmenované parametry 🤔 ale vlastně nevím.
There was a problem hiding this comment.
SECRET jsme vyhodili, pac se ted vsude pouziva Managed identity.
Ale aby se secret nevypisoval do query, tak bude vhodne pouzit funkci, napr. secret(...).
There was a problem hiding this comment.
mělo by tam imho pak byt SECRET=? a udělat parameter bind v SQL, tak abysme ten secret nelogovali, případně ho v eventě replacnůt za hvězdičky
Jira: KBC-2928
Sample
data/config.json:{ "parameters": { "backend": "synapse", "operation": "importFull", "source": "table", "columns": [ "aaa", "bbb" ], "primaryKeys": [ "aaa", "bbb" ] }, "action": "generate" }Supported combinations (backend, operation, source):