Update to support more dbs #20
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivnicek
commented
Nov 22, 2024
Comment on lines
+50
to
+56
| private const BYODB_DATABASES = [ | ||
| 'coates' => [ | ||
| 'db_replica_prefix' => 'COATESAWSUS', | ||
| 'db_prefix' => 'KEBOOLA', | ||
| 'account' => 'COATES', | ||
| 'region' => 'AWS_US_EAST_1', | ||
| ], |
There was a problem hiding this comment.
@ondrajodas what do you think of this approach?
There was a problem hiding this comment.
@ondrajodas co myslis, mam pokracovat?
There was a problem hiding this comment.
podle mě tohle nemusíš vůbec dělat, stačí to co je na ř. 42
There was a problem hiding this comment.
nevím čeho by si chtěl tímhle dosáhnout? co vlastně potřebuješ udělat?
There was a problem hiding this comment.
Tenhle na ř. 42 je Target DB.
Ale source DB je BYODB na connection.keboola.com
There was a problem hiding this comment.
@ondrajodas migrujem z byodb do single tenant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.