Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES-217 support workspaces and external buckets #21

Merged
merged 4 commits into from
Feb 10, 2025
Merged

ES-217 support workspaces and external buckets #21

merged 4 commits into from
Feb 10, 2025

Conversation

pivnicek
Copy link
Contributor

  • add support for migrating the data of given workspace schemas and external schemas

@ondrajodas ondrajodas changed the base branch from master to ES-216-add-byodb February 4, 2025 10:48
@pivnicek pivnicek changed the base branch from ES-216-add-byodb to master February 5, 2025 12:02
@pivnicek pivnicek changed the base branch from master to ES-216-add-byodb February 5, 2025 12:03
@pivnicek pivnicek force-pushed the ES-217-workspaces-and-external-buckets branch from 57405ac to 4f678a8 Compare February 5, 2025 12:09
@pivnicek pivnicek marked this pull request as ready for review February 5, 2025 12:11
@pivnicek pivnicek requested a review from ondrajodas February 5, 2025 12:14
ondrajodas
ondrajodas reviewed Feb 6, 2025
View reviewed changes
src/Config.php Outdated
return $this->getArrayValue(['parameters', 'includeWorkspaceSchemas']);
}

public function getIncludedExternalSchemas(): array
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tohle pls ještě smázni

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 dik!

Base automatically changed from ES-216-add-byodb to master February 6, 2025 09:05
@pivnicek pivnicek requested a review from ondrajodas February 6, 2025 10:05
ondrajodas
ondrajodas approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@ondrajodas ondrajodas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ondrajodas ondrajodas merged commit eac0746 into master Feb 10, 2025
4 checks passed
@ondrajodas ondrajodas deleted the ES-217-workspaces-and-external-buckets branch February 10, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrajodas ondrajodas ondrajodas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pivnicek @ondrajodas