Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set setUp method as protected as it should be #16

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Set setUp method as protected as it should be #16

merged 1 commit into from
Nov 5, 2018

Conversation

tomasfejfar
Copy link
Contributor

Zatahlo se to tam omylem s opravou temp složky. A je to BC break (protože předtím fungující protected function setUp musí teď být public).

@tomasfejfar tomasfejfar requested review from Actimel and odinuv November 5, 2018 10:41
odinuv
odinuv approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@odinuv odinuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nj, ma to byt protected https://github.com/sebastianbergmann/phpunit/blob/bcbb5e070a7068df8a6daa3028940566bc2929b7/src/Framework/TestCase.php#L407

@tomasfejfar tomasfejfar merged commit 5653b5f into master Nov 5, 2018
@tomasfejfar tomasfejfar deleted the fix-setup branch November 5, 2018 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odinuv odinuv odinuv approved these changes

@Actimel Actimel Awaiting requested review from Actimel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasfejfar @odinuv