Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PST-2248: Update db-extractor-adapter to ^1.15 #189

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

romantmb
Copy link
Contributor

https://keboola.atlassian.net/browse/PST-2248

Update db-extractor-adapter for

@romantmb
Copy link
Contributor Author

@ondrajodas Btw mysql:latest už je 9.1. Nestálo by za to přihodit devítku do testů?

@romantmb romantmb requested a review from ondrajodas November 22, 2024 11:57
@ondrajodas
Copy link
Contributor

zkus ji tam přidat jestli proběhnou testy a jestli neprojdou tak založ issue a dej ho do dalšího sprintu Markovi :-)

@romantmb
Copy link
Contributor Author

romantmb commented Nov 25, 2024

zkus ji tam přidat jestli proběhnou testy a jestli neprojdou tak založ issue a dej ho do dalšího sprintu Markovi :-)T

Tak bohužel tam některé testy popadaly na OpenSSL, takže založím issue.

EDIT: https://keboola.atlassian.net/browse/PST-2286

@ondrajodas
Copy link
Contributor

@romantmb nemě by se ještě upravit common a na tu specifickou exceptionu udělat retry?

@romantmb
Copy link
Contributor Author

romantmb commented Nov 26, 2024

@romantmb nemě by se ještě upravit common a na tu specifickou exceptionu udělat retry?

@ondrajodas Na to je navazující task: https://keboola.atlassian.net/browse/PST-2218
V té první fázi jsme chtěli, aby se detekovalo, že je to zavřenej ssh tunnel, a aby se to zalogovalo.

Copy link
Contributor

@ondrajodas ondrajodas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jo jasně, v tom případě OK

@romantmb romantmb merged commit 4b7500a into master Nov 26, 2024
10 checks passed
@romantmb romantmb deleted the roman-pst-2248 branch November 26, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants