Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor staging-provider #762

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Refactor staging-provider #762

merged 2 commits into from
Sep 18, 2024

Conversation

odinuv
Copy link
Member

@odinuv odinuv commented Sep 13, 2024

composer.json Outdated Show resolved Hide resolved
@odinuv odinuv changed the title wip Refactor staging-provider Sep 14, 2024
@odinuv odinuv force-pushed the odin-KAB-257 branch 2 times, most recently from 797b7ed to 741b44d Compare September 15, 2024 07:36
@odinuv odinuv marked this pull request as ready for review September 15, 2024 11:13
Copy link
Contributor

@pepamartinec pepamartinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A ted jeste jednou tu https://github.com/keboola/job-queue/tree/main/libs/job-configuration/src/Mapping a predpokladam ze i nejak do data-loader-api/sandboxes komponenty 🙂

Tests/BaseRunnerTest.php Outdated Show resolved Hide resolved
src/Docker/Runner/DataLoader/DataLoader.php Outdated Show resolved Hide resolved
src/Docker/Runner/DataLoader/DataLoader.php Show resolved Hide resolved
Copy link
Contributor

@pepamartinec pepamartinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.. jeste teda co s timto? Mas na to nejaky task?

A ted jeste jednou tu https://github.com/keboola/job-queue/tree/main/libs/job-configuration/src/Mapping a predpokladam ze i nejak do data-loader-api/sandboxes komponenty 🙂

@odinuv
Copy link
Member Author

odinuv commented Sep 17, 2024

založil jsem
https://keboola.atlassian.net/browse/KAB-312
https://keboola.atlassian.net/browse/KAB-313

Copy link
Contributor

@pepamartinec pepamartinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, tak snad tam nezapadnou

fix type hint
use prod dependency
@odinuv odinuv merged commit f545ff5 into main Sep 18, 2024
12 checks passed
@odinuv odinuv deleted the odin-KAB-257 branch September 18, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants