Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove approvalReceived event #15

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Remove approvalReceived event #15

merged 1 commit into from
Jul 20, 2023

Conversation

jirkasemmler
Copy link
Contributor

@jirkasemmler jirkasemmler commented Jul 20, 2023 •
edited
Loading

Before asking for review make sure that:

  • you created a task for KBC team to update event-schema in Connection (validation in API endpoint)
  • you notified everyone in #general that even schema is changing - I did not, because noone cares about such event

they aren't needed anymore.

@jirkasemmler jirkasemmler requested a review from tomasfejfar July 20, 2023 07:36
tomasfejfar
tomasfejfar approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@tomasfejfar tomasfejfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jirkasemmler jirkasemmler merged commit ee9abbb into main Jul 20, 2023
@jirkasemmler jirkasemmler deleted the remove-approvalReceived-event branch July 20, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasfejfar tomasfejfar tomasfejfar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jirkasemmler @tomasfejfar