feat: Cleanup Stream events #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jachym-tousek-keboola
force-pushed
the
jt-cleanup-stream-events
branch
from
a146774 to
d7f0423
Compare
Matovidlo
reviewed
Nov 5, 2024
jachym-tousek-keboola
force-pushed
the
jt-cleanup-stream-events
branch
2 times, most recently
from
a03d99a to
93dfe1c
Compare
|
okay, added the purge event back |
tomasfejfar
approved these changes
Nov 7, 2024
jachym-tousek-keboola
force-pushed
the
jt-cleanup-stream-events
branch
from
93dfe1c to
10f28e1
Compare
Matovidlo
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up the event schema. IDs are in params, statistics and err in results for all events.
It could be argued that fileImport and sliceUpload could have everything in results as they're background operations but for telemetry team convenience I think it's better to have the ids consistently in params.
Don't merge yet, we need to wait for telemetry team to update things first. I just want to validate it with you first.