remove enabled node

keboola · Jan 4, 2021 · 6894a0e · 6894a0e
1 parent 7ec4630
commit 6894a0e
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 16 deletions.
diff --git a/src/Configuration/ConfigDefinition.php b/src/Configuration/ConfigDefinition.php
@@ -42,9 +42,6 @@ protected function getParametersDefinition(): ArrayNodeDefinition
                                 ->isRequired()
                                 ->cannotBeEmpty()
                             ->end()
-                            ->booleanNode('enabled')
-                                ->defaultValue(true)
-                            ->end()
                             ->arrayNode('header')
                                 ->addDefaultsIfNotSet()
                                 ->children()

diff --git a/src/Extractor/Extractor.php b/src/Extractor/Extractor.php
@@ -51,10 +51,6 @@ public function run(array $sheets): array
         $exceptionHandler = new ExceptionHandler();
 
         foreach ($sheets as $sheet) {
-            if (!$sheet['enabled']) {
-                continue;
-            }
-
             try {
                 $spreadsheet = $this->driveApi->getSpreadsheet($sheet['fileId']);
                 $this->logger->info('Obtained spreadsheet metadata');

diff --git a/tests/phpunit/BaseTest.php b/tests/phpunit/BaseTest.php
@@ -61,7 +61,6 @@ protected function makeConfig(array $testFile): array
             'sheetId' => $testFile['sheets'][0]['properties']['sheetId'],
             'sheetTitle' => $testFile['sheets'][0]['properties']['title'],
             'outputTable' => $this->testFileName,
-            'enabled' => true,
         ];
 
         return $config;

diff --git a/tests/phpunit/Extractor/ExceptionHandleTest.php b/tests/phpunit/Extractor/ExceptionHandleTest.php
@@ -50,7 +50,6 @@ public function provideExceptionsForGetSpreadsheet(): array
                     'sheetTitle' => 'Title XXXXXX',
                     'outputTable' => 'table',
                     'header' => ['rows' => 1, 'columns' => []],
-                    'enabled' => true,
                 ],
             ],
             'http404' => [
@@ -70,7 +69,6 @@ public function provideExceptionsForGetSpreadsheet(): array
                     'sheetTitle' => 'Title XXXXXX',
                     'outputTable' => 'table',
                     'header' => ['rows' => 1, 'columns' => []],
-                    'enabled' => true,
                 ],
             ],
             'other request exception without description' => [
@@ -90,7 +88,6 @@ public function provideExceptionsForGetSpreadsheet(): array
                     'sheetTitle' => 'Title XXXXXX',
                     'outputTable' => 'table',
                     'header' => ['rows' => 1, 'columns' => []],
-                    'enabled' => true,
                 ],
             ],
             'other request exception with description' => [
@@ -111,7 +108,6 @@ public function provideExceptionsForGetSpreadsheet(): array
                     'sheetTitle' => 'Title XXXXXX',
                     'outputTable' => 'table',
                     'header' => ['rows' => 1, 'columns' => []],
-                    'enabled' => true,
                 ],
             ],
             'other random exception' => [
@@ -128,7 +124,6 @@ public function provideExceptionsForGetSpreadsheet(): array
                     'sheetTitle' => 'Title XXXXXX',
                     'outputTable' => 'table',
                     'header' => ['rows' => 1, 'columns' => []],
-                    'enabled' => true,
                 ],
             ],
             'exception with another response array ' => [
@@ -150,7 +145,6 @@ public function provideExceptionsForGetSpreadsheet(): array
                     'sheetTitle' => 'Title XXXXXX',
                     'outputTable' => 'table',
                     'header' => ['rows' => 1, 'columns' => []],
-                    'enabled' => true,
                 ],
             ],
         ];
@@ -192,7 +186,6 @@ public function provideExceptionsForExport(): array
                     'sheetTitle' => 'Title XXXXXX',
                     'outputTable' => 'table',
                     'header' => ['rows' => 1, 'columns' => []],
-                    'enabled' => true,
                 ],
             ],
         ];

diff --git a/tests/phpunit/data/config.json b/tests/phpunit/data/config.json
@@ -8,7 +8,6 @@
         "sheetId": null,
         "sheetTitle": null,
         "outputTable": null,
-        "enabled": true,
         "header": {
           "rows": 1
         }