Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use php component #31

Merged
merged 3 commits into from
Jan 4, 2021
Merged

Use php component #31

merged 3 commits into from
Jan 4, 2021

Conversation

ondrajodas
Copy link
Contributor

@ondrajodas ondrajodas changed the base branch from master to COM-592-ondra-use-json-config December 28, 2020 15:10
@ondrajodas ondrajodas marked this pull request as ready for review December 28, 2020 15:51
michaljurecko
michaljurecko approved these changes Jan 4, 2021
View reviewed changes
Copy link

@michaljurecko michaljurecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ondrajodas ondrajodas force-pushed the COM-592-ondra-use-json-config branch from cea9d13 to 3916529 Compare January 4, 2021 08:39
Base automatically changed from COM-592-ondra-use-json-config to master January 4, 2021 08:49
@ondrajodas ondrajodas force-pushed the COM-591-ondra-use-php-component branch from 0cce30a to 745bc97 Compare January 4, 2021 08:50
@ondrajodas ondrajodas merged commit 7ec4630 into master Jan 4, 2021
@ondrajodas ondrajodas deleted the COM-591-ondra-use-php-component branch January 4, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaljurecko michaljurecko michaljurecko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ondrajodas @michaljurecko