Merge pull request #1815 from keboola/lint-add-musttag-linter

lint: Add musttag linter.
keboola · Nov 22, 2024 · 61dfa30 · 61dfa30
2 parents f5f5d85 + 036ec35
commit 61dfa30
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/build/ci/golangci.yml b/build/ci/golangci.yml
@@ -138,6 +138,7 @@ linters:
     - ineffassign
     - intrange
     - makezero
+    - musttag
     - nakedret
     - nilerr
     - noctx

diff --git a/internal/pkg/service/common/etcdop/op/op_test.go b/internal/pkg/service/common/etcdop/op/op_test.go
@@ -21,7 +21,7 @@ type testOp struct {
 }
 
 type testValue struct {
-	Foo string
+	Foo string `json:"foo"`
 }
 
 type opTestCase[R any] struct {

diff --git a/internal/pkg/service/stream/api/mapper/task.go b/internal/pkg/service/stream/api/mapper/task.go
@@ -56,7 +56,7 @@ func (m *Mapper) NewTaskResponse(entity task.Task) (*api.Task, error) {
 	// Outputs
 	if entity.Outputs != nil {
 		response.Outputs = &api.TaskOutputs{}
-		err := mapstructure.Decode(entity.Outputs, response.Outputs)
+		err := mapstructure.Decode(entity.Outputs, response.Outputs) // nolint: musttag
 		if err != nil {
 			return nil, err
 		}

diff --git a/internal/pkg/service/stream/migrate/core/source.go b/internal/pkg/service/stream/migrate/core/source.go
@@ -128,7 +128,7 @@ func (r *Receiver) createSourcePayload() (*bytes.Buffer, error) {
 	}
 
 	payloadBuf := new(bytes.Buffer)
-	err := json.NewEncoder(payloadBuf).Encode(s)
+	err := json.NewEncoder(payloadBuf).Encode(s) // nolint:musttag
 	if err != nil {
 		return nil, err
 	}

diff --git a/test/stream/bridge/keboola/setup_test.go b/test/stream/bridge/keboola/setup_test.go
@@ -316,7 +316,7 @@ func (ts *testState) setupSourceThroughAPI(t *testing.T, ctx context.Context, ex
 		Type:     "http",
 		Name:     "testSource",
 	}
-	out, err := json.Marshal(payload)
+	out, err := json.Marshal(payload) // nolint:musttag
 	if !assert.NoError(t, err) {
 		ts.logger.Errorf(ctx, "unable to marshal source create payload: %v", err)
 		return
@@ -369,7 +369,7 @@ func (ts *testState) setupSinkThroughAPI(t *testing.T, ctx context.Context, expe
 		Type:     definition.SinkTypeTable,
 		Name:     "testSink",
 	}
-	out, err := json.Marshal(payload)
+	out, err := json.Marshal(payload) // nolint:musttag
 	if !assert.NoError(t, err) {
 		ts.logger.Errorf(ctx, "unable to marshal sink create payload: %v", err)
 		return