fix: Race condition on span with defer in errgrp

keboola · Nov 20, 2024 · 665e97a · 665e97a
1 parent 0412bce
commit 665e97a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/internal/pkg/service/stream/storage/metacleanup/metacleanup.go b/internal/pkg/service/stream/storage/metacleanup/metacleanup.go
@@ -184,13 +184,13 @@ func (n *Node) cleanMetadata(ctx context.Context) (err error) {
 
 				// Trace each job
 				ctx, span := n.telemetry.Tracer().Start(ctx, "keboola.go.stream.model.cleanup.metadata.cleanJob")
-				defer span.End(&err)
 
 				err, deleted := n.bridge.CleanJob(ctx, job)
 				if deleted {
 					jobCounter.Add(1)
 				}
 
+				span.End(&err)
 				return err
 			})