Skip to content

Commit

Permalink
hotfix: Pipeline does not test all code, just one that it is expected…
Browse files Browse the repository at this point in the history
… to be released
  • Loading branch information
Matovidlo committed Nov 21, 2024
1 parent 5585d40 commit 8153aee
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ jobs:
name: "Unit Tests"
secrets: inherit
uses: ./.github/workflows/test-unit.yml
with:
test-regex: ./internal/pkg/service/stream

test-e2e-cli:
name: "E2E: CLI"
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release-cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ jobs:
uses: ./.github/workflows/test-unit.yml
with:
without-cache: true
test-regex: ./internal/pkg/service/stream

test-e2e-cli:
name: "E2E: CLI"
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/test-unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ on:
type: boolean
default: false
required: false
test-regex:
type: string
default: ""
required: false

env:
TEST_PARALLELISM: 12
Expand Down Expand Up @@ -90,7 +94,9 @@ jobs:
if [ "$RUNNER_OS" == "macOS" ]; then
export GOFLAGS="-ldflags=-extldflags=-Wl,-ld_classic"
fi
echo $TEST_EXCEPT
# ENVs can affect test caching, make sure to only run tests with expected ENVs
env -i \
TERM="$TERM" \
Expand All @@ -117,4 +123,6 @@ jobs:
TEST_KBC_PROJECTS_LOCK_PASSWORD: ${{ secrets.TEST_KBC_PROJECTS_LOCK_PASSWORD }}
TEST_KBC_PROJECTS_FILE: '${{ github.workspace }}/${{ vars.TEST_KBC_PROJECTS_FILE }}'
UNIT_ETCD_ENABLED: ${{ matrix.name == 'linux' && 'true' || 'false' }}
# Prevent testing unnecessary code for particular release
TEST_EXCEPT: "go list ./internal/pkg/... | grep -v '${{ inputs.test-regex }}'"

4 changes: 4 additions & 0 deletions scripts/tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ TEST_LOG_FORMAT="${TEST_LOG_FORMAT:=testname}"
TEST_DETECT_RACE="${TEST_DETECT_RACE:=true}"
TEST_COVERAGE="${TEST_COVERAGE:=true}"
TEST_PACKAGE="${TEST_PACKAGE:=./...}"
TEST_EXCEPT="${TEST_EXCEPT:=}"
TEST_ARGS="${TEST_ARGS:=}"
if [[ $TEST_VERBOSE == "true" ]]; then
TEST_ARGS="$TEST_ARGS -v"
Expand All @@ -28,6 +29,9 @@ fi
if [[ $TEST_COVERAGE == "true" ]]; then
TEST_ARGS="$TEST_ARGS -coverprofile=/tmp/profile.out"
fi
if [[ -n $TEST_EXCEPT ]]; then
TEST_PACKAGE="\$($TEST_EXCEPT)"
fi

# Run tests, sequentially because the API is shared resource
echo "Running tests ..."
Expand Down

0 comments on commit 8153aee

Please sign in to comment.