Merge pull request #1816 from keboola/lint-add-linters

lint: Add new linters without code change. Add new disabled linters.
keboola · Nov 25, 2024 · b1ba99a · b1ba99a
2 parents d09d394 + 73a56d0
commit b1ba99a
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 4 deletions.
diff --git a/build/ci/golangci.yml b/build/ci/golangci.yml
@@ -112,21 +112,27 @@ linters:
   disable-all: true
   enable:
     - asciicheck
+    - bidichk
     - bodyclose
     - contextcheck
+    - decorder
     - depguard
     - dogsled
     - dupl
     - durationcheck
     - errcheck
+    - errchkjson
     - errname
     - errorlint
     - exhaustive
     - copyloopvar
     - forbidigo
     - gci
+    - ginkgolinter
+    - gocheckcompilerdirectives
     - gochecknoglobals
-    #- gochecknoinits - temporary disabled https://github.com/golangci/golangci-lint/issues/4697
+    - gochecknoinits
+    - gochecksumtype
     - goconst
     - gocritic
     - godot
@@ -135,9 +141,11 @@ linters:
     - goheader
     - gomodguard
     - goprintffuncname
+    - gosmopolitan
     - gosec
     - gosimple
     - govet
+    - grouper
     - importas
     - inamedparam
     - ineffassign
@@ -150,12 +158,14 @@ linters:
     - prealloc
     - predeclared
     - promlinter
+    - reassign
     - rowserrcheck
     - sqlclosecheck
     - staticcheck
     - stylecheck
     - tagliatelle
     - testifylint
+    - tenv
     - thelper
     - tparallel
     - paralleltest
@@ -172,11 +182,22 @@ linters:
     #- gomoddirectives # allow replace directive in go.mod
     #- misspell - broken, rewrites code
     # TODO
+    #- canonicalheader # when enabled skip old headers from linting e.g X-StorageAPI-Token
+    #- containedctx
+    #- dupword
+    #- exhaustruct
     #- funlen
+    #- forcetypeassert
     #- gocyclo
     #- gocognit
     #- cyclop
+    #- maintidx
+    #- mnd
     #- nestif
+    #- nlreturn
+    #- nosprintfhostport
+    #- spancheck
+    #- testpackage
     #- lll
     #- gomnd
 

diff --git a/internal/pkg/utils/testhelper/testtemplateinputs/testtemplateinputs_test.go b/internal/pkg/utils/testhelper/testtemplateinputs/testtemplateinputs_test.go
@@ -12,9 +12,9 @@ import (
 func TestNewUserErrorWithCode(t *testing.T) {
 	t.Parallel()
 
-	require.NoError(t, os.Setenv("CUSTOM_ENV", "val1"))      //nolint:forbidigo
-	require.NoError(t, os.Setenv("KBC_SECRET_VAR2", "val2")) //nolint:forbidigo
-	require.NoError(t, os.Setenv("KBC_SECRET_VAR3", "val3")) //nolint:forbidigo
+	require.NoError(t, os.Setenv("CUSTOM_ENV", "val1"))      //nolint:forbidigo, tenv
+	require.NoError(t, os.Setenv("KBC_SECRET_VAR2", "val2")) //nolint:forbidigo, tenv
+	require.NoError(t, os.Setenv("KBC_SECRET_VAR3", "val3")) //nolint:forbidigo, tenv
 
 	provider, err := CreateTestInputsEnvProvider(context.Background())
 	require.NoError(t, err)