Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Add intrange linter to reduce code complexity. #1811

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

Matovidlo
Copy link
Contributor

@Matovidlo Matovidlo commented Jun 4, 2024

Jira: PSGO-682

Changes:

  • Add intrange linter to reduce code complexity when using simple for loop.

@Matovidlo Matovidlo force-pushed the lint-add-intrange-linter branch 26 times, most recently from 36f93ab to 6c09b97 Compare June 12, 2024 06:25
@Matovidlo Matovidlo requested a review from michaljurecko June 14, 2024 08:55
@Matovidlo Matovidlo force-pushed the lint-add-intrange-linter branch from a4dbe33 to 2821a8d Compare November 20, 2024 10:04
Copy link
Contributor

@jachym-tousek-keboola jachym-tousek-keboola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but the CI is failing.

Also the dots at the end of commit messages are unnecessary...

@Matovidlo
Copy link
Contributor Author

@jachym-tousek-keboola yea working on CI. The commits are from before, I'll try to remove them in next PRs 👍

@Matovidlo Matovidlo merged commit 15942a2 into main Nov 22, 2024
12 checks passed
@Matovidlo Matovidlo deleted the lint-add-intrange-linter branch November 22, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants