lint: Add testableexamples linter to have examples correctly tested. #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matovidlo
force-pushed
the
lint-add-testableexamples-linter
branch
2 times, most recently
from
51b7c18 to
f2cf032
Compare
Matovidlo
force-pushed
the
lint-add-testableexamples-linter
branch
from
f2cf032 to
a7d1fac
Compare
Comment on lines
-41
to
46
| fmt.Println(errors.Format(err, errors.FormatWithStack())) | ||
| re := regexp.MustCompile(`\[.*/internal`) | ||
| fmt.Println(string(re.ReplaceAll([]byte(errors.Format(err, errors.FormatWithStack())), []byte("[")))) | ||
| // output: | ||
| // original error [/pkg/utils/errors/example_test.go:40] | ||
| } |
There was a problem hiding this comment.
Examples without tests also make sense, for documentation.
Is it possible to define the output for each example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: PSGO-682
Changes:
Examplecorrectly tested. (output have to be tested otherwise it makes no sense).