lint: Add testifylint to prevent unnecessary test code issues #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matovidlo
force-pushed
the
lint-add-testifylint-linter
branch
2 times, most recently
from
25b8a7f to
e5a0e34
Compare
michaljurecko
suggested changes
Jun 14, 2024
Comment on lines
-25
to
34
| assert.NoError(t, projectState.Set(branchState)) | ||
| require.NoError(t, projectState.Set(branchState)) | ||
|
|
||
| d := NewDiffer(projectState) | ||
| results, err := d.Diff() | ||
| assert.NoError(t, err) | ||
| require.NoError(t, err) | ||
| assert.Len(t, results.Results, 1) | ||
| result := results.Results[0] | ||
| assert.Equal(t, ResultOnlyInLocal, result.State) |
There was a problem hiding this comment.
Sometimes it makes sense for the test to continue, so you get the overall picture and you don't have to run the test repeatedly.
I prefer to use assert and require only when there is no point in continuing.
There was a problem hiding this comment.
Should you continue when err is not nil? If yes then use if assert.NoError(t, err); err != nil { } Otherwise it makes sense. I don't see anything else just a plain help to prevent unnecessary panics in test code. When you do not care about error, just omit it using _
Matovidlo
force-pushed
the
lint-add-testifylint-linter
branch
from
e5a0e34 to
35df6fa
Compare
Matovidlo
requested review from
jachym-tousek-keboola and
hosekpeter
as code owners
Matovidlo
force-pushed
the
lint-add-testifylint-linter
branch
from
35df6fa to
65d07ab
Compare
jachym-tousek-keboola
removed request for
hosekpeter and
jachym-tousek-keboola
Matovidlo
force-pushed
the
lint-add-testifylint-linter
branch
from
65d07ab to
f305538
Compare
Templates API Kubernetes Diff [CI]Between Expand--- /tmp/artifacts/test-k8s-state.old.json.processed.kv 2024-11-22 12:48:36.419878086 +0000
+++ /tmp/artifacts/test-k8s-state.new.json.processed.kv 2024-11-22 12:48:36.651878699 +0000
@@ -194 +194 @@
-<Deployment/templates-api>.spec.template.spec.containers[0].image = "docker.io/keboola/templates-api:849e4bf-1732279046";
+<Deployment/templates-api>.spec.template.spec.containers[0].image = "docker.io/keboola/templates-api:f766f90-1732279361";
@@ -747,3 +747,3 @@
-<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:849e4bf-1732279046";
-<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:849e4bf-1732279046";
-<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:849e4bf-1732279046";
+<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:f766f90-1732279361";
+<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:f766f90-1732279361";
+<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:f766f90-1732279361";
@@ -1417 +1417 @@
-<ReplicaSet/templates-api-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/templates-api:849e4bf-1732279046";
+<ReplicaSet/templates-api-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/templates-api:f766f90-1732279361";
@@ -1488,0 +1489,12 @@
+<Secret/sh.helm.release.v1.templates-api-etcd.v2> = {};
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.apiVersion = "v1";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.data = {};
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.kind = "Secret";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata = {};
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.labels = {};
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.labels.name = "templates-api-etcd";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.labels.owner = "helm";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.labels.version = "2";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.name = "sh.helm.release.v1.templates-api-etcd.v2";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.namespace = "templates-api";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.type = "helm.sh/release.v1";
(see artifacts in the Github Action for more information) |
jachym-tousek-keboola
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: PSGO-682
Changes: