Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move format.go -> sourcenode/format/format.go #1880

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

michaljurecko
Copy link
Contributor

@michaljurecko michaljurecko commented Jul 3, 2024

Jira: https://keboola.atlassian.net/browse/PSGO-597

Changes:

  • Moved files/packages, to split responsibilities between: diskreader, diskwriter and encoding (source).

@michaljurecko michaljurecko force-pushed the michaljurecko-PSGO-591-format-pkg branch from d6ce1e9 to f541d85 Compare July 3, 2024 15:37
@michaljurecko michaljurecko changed the title refactor: Move format.go -> sourcenode/forat/format.go refactor: Move format.go -> sourcenode/format/format.go Jul 3, 2024
@michaljurecko michaljurecko force-pushed the michaljurecko-PSGO-591-format-pkg branch from f541d85 to 90682f3 Compare July 3, 2024 15:42
@michaljurecko michaljurecko force-pushed the michaljurecko-PSGO-591-format-pkg branch from 90682f3 to db7e527 Compare July 4, 2024 05:39
Copy link

github-actions bot commented Jul 4, 2024

Apps Proxy Kubernetes Diff [CI]

Between base 09c9a76 ⬅️ head 4191b07.

Expand
--- /tmp/artifacts/test-k8s-state.old.json.processed.kv	2024-07-04 06:12:45.553775797 +0000
+++ /tmp/artifacts/test-k8s-state.new.json.processed.kv	2024-07-04 06:12:45.673775982 +0000
@@ -105 +105 @@
-<Deployment/apps-proxy>.spec.template.spec.containers[0].image = "docker.io/keboola/apps-proxy:09c9a76-1720073217";
+<Deployment/apps-proxy>.spec.template.spec.containers[0].image = "docker.io/keboola/apps-proxy:4191b07-1720073456";
@@ -461,3 +461,3 @@
-<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:09c9a76-1720073217";
-<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:09c9a76-1720073217";
-<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:09c9a76-1720073217";
+<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:4191b07-1720073456";
+<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:4191b07-1720073456";
+<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:4191b07-1720073456";
@@ -879 +879 @@
-<ReplicaSet/apps-proxy-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/apps-proxy:09c9a76-1720073217";
+<ReplicaSet/apps-proxy-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/apps-proxy:4191b07-1720073456";


(see artifacts in the Github Action for more information)

Copy link

github-actions bot commented Jul 4, 2024

Templates API Kubernetes Diff [CI]

Between base 09c9a76 ⬅️ head 4191b07.

Expand
--- /tmp/artifacts/test-k8s-state.old.json.processed.kv	2024-07-04 06:14:19.664278873 +0000
+++ /tmp/artifacts/test-k8s-state.new.json.processed.kv	2024-07-04 06:14:19.856281937 +0000
@@ -194 +194 @@
-<Deployment/templates-api>.spec.template.spec.containers[0].image = "docker.io/keboola/templates-api:09c9a76-1720073203";
+<Deployment/templates-api>.spec.template.spec.containers[0].image = "docker.io/keboola/templates-api:4191b07-1720073493";
@@ -747,3 +747,3 @@
-<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:09c9a76-1720073203";
-<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:09c9a76-1720073203";
-<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:09c9a76-1720073203";
+<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:4191b07-1720073493";
+<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:4191b07-1720073493";
+<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:4191b07-1720073493";
@@ -1414 +1414 @@
-<ReplicaSet/templates-api-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/templates-api:09c9a76-1720073203";
+<ReplicaSet/templates-api-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/templates-api:4191b07-1720073493";
@@ -1485,0 +1486,12 @@
+<Secret/sh.helm.release.v1.templates-api-etcd.v2> = {};
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.apiVersion = "v1";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.data = {};
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.kind = "Secret";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata = {};
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.labels = {};
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.labels.name = "templates-api-etcd";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.labels.owner = "helm";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.labels.version = "2";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.name = "sh.helm.release.v1.templates-api-etcd.v2";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.namespace = "templates-api";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.type = "helm.sh/release.v1";


(see artifacts in the Github Action for more information)

@michaljurecko michaljurecko marked this pull request as ready for review July 8, 2024 09:58
Base automatically changed from michaljurecko-PSGO-591-move-pkgs to main July 9, 2024 06:22
@michaljurecko michaljurecko merged commit e1d08b0 into main Jul 9, 2024
14 checks passed
@michaljurecko michaljurecko deleted the michaljurecko-PSGO-591-format-pkg branch July 9, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants