Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reduce cognitive complexity of functions in storage level writer. #1917

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Reduce cognitive complexity of functions in storage level writer. #1917

wants to merge 1 commit into from

Conversation

Matovidlo
Copy link
Contributor

Jira: XXXXX

Changes:

  • ...

@Matovidlo Matovidlo changed the base branch from main to michaljurecko-PSGO-591-source-wirter-assignment July 17, 2024 12:33
@github-actions GitHub Actions
Copy link

Stream Kubernetes Diff [CI]

Between base b6561fb ⬅️ head 74b537f.

Expand 
--- /tmp/artifacts/test-k8s-state.old.json.processed.kv	2024-07-17 12:45:01.728163406 +0000
+++ /tmp/artifacts/test-k8s-state.new.json.processed.kv	2024-07-17 12:45:02.224157074 +0000
@@ -13 +13 @@
-<ConfigMap/stream-config>.data["config.yaml"] = "###############################################################################################...
+<ConfigMap/stream-config>.data["config.yaml"] = "###############################################################################################...
@@ -197 +197 @@
-<Deployment/stream-api>.spec.template.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<Deployment/stream-api>.spec.template.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
@@ -358 +358 @@
-<Deployment/stream-http-source>.spec.template.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<Deployment/stream-http-source>.spec.template.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
@@ -516 +516 @@
-<Deployment/stream-storage-coordinator>.spec.template.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<Deployment/stream-storage-coordinator>.spec.template.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
@@ -1201,2 +1201,2 @@
-<Pod/stream-api-<hash>>.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
-<Pod/stream-api-<hash>>.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<Pod/stream-api-<hash>>.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
+<Pod/stream-api-<hash>>.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
@@ -1521 +1521 @@
-<Pod/stream-etcd-0>.spec.containers[0].env[21].value = "new";
+<Pod/stream-etcd-0>.spec.containers[0].env[21].value = "existing";
@@ -1763 +1763 @@
-<Pod/stream-etcd-1>.spec.containers[0].env[21].value = "new";
+<Pod/stream-etcd-1>.spec.containers[0].env[21].value = "existing";
@@ -2077,2 +2077,2 @@
-<Pod/stream-http-source-<hash>>.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
-<Pod/stream-http-source-<hash>>.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<Pod/stream-http-source-<hash>>.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
+<Pod/stream-http-source-<hash>>.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
@@ -2463,2 +2463,2 @@
-<Pod/stream-storage-coordinator-<hash>>.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
-<Pod/stream-storage-coordinator-<hash>>.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<Pod/stream-storage-coordinator-<hash>>.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
+<Pod/stream-storage-coordinator-<hash>>.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
@@ -2693 +2693 @@
-<Pod/stream-storage-writer-reader-0>.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<Pod/stream-storage-writer-reader-0>.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
@@ -2772 +2772 @@
-<Pod/stream-storage-writer-reader-0>.spec.containers[1].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<Pod/stream-storage-writer-reader-0>.spec.containers[1].image = "docker.io/keboola/stream-api:74b537f-1721220054";
@@ -2824 +2824 @@
-<Pod/stream-storage-writer-reader-0>.spec.volumes[0].persistentVolumeClaim.claimName = "fast-001-stream-storage-writer-reader-0";
+<Pod/stream-storage-writer-reader-0>.spec.volumes[0].persistentVolumeClaim.claimName = "medium-001-stream-storage-writer-reader-0";
@@ -2827 +2827 @@
-<Pod/stream-storage-writer-reader-0>.spec.volumes[1].persistentVolumeClaim.claimName = "medium-001-stream-storage-writer-reader-0";
+<Pod/stream-storage-writer-reader-0>.spec.volumes[1].persistentVolumeClaim.claimName = "slow-001-stream-storage-writer-reader-0";
@@ -2830 +2830 @@
-<Pod/stream-storage-writer-reader-0>.spec.volumes[2].persistentVolumeClaim.claimName = "slow-001-stream-storage-writer-reader-0";
+<Pod/stream-storage-writer-reader-0>.spec.volumes[2].persistentVolumeClaim.claimName = "fast-001-stream-storage-writer-reader-0";
@@ -2946 +2946 @@
-<Pod/stream-storage-writer-reader-1>.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<Pod/stream-storage-writer-reader-1>.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
@@ -3025 +3025 @@
-<Pod/stream-storage-writer-reader-1>.spec.containers[1].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<Pod/stream-storage-writer-reader-1>.spec.containers[1].image = "docker.io/keboola/stream-api:74b537f-1721220054";
@@ -3270 +3270 @@
-<ReplicaSet/stream-api-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<ReplicaSet/stream-api-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
@@ -3438 +3438 @@
-<ReplicaSet/stream-http-source-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<ReplicaSet/stream-http-source-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
@@ -3603 +3603 @@
-<ReplicaSet/stream-storage-coordinator-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<ReplicaSet/stream-storage-coordinator-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
@@ -3644,0 +3645,12 @@
+<Secret/sh.helm.release.v1.stream-etcd.v2> = {};
+<Secret/sh.helm.release.v1.stream-etcd.v2>.apiVersion = "v1";
+<Secret/sh.helm.release.v1.stream-etcd.v2>.data = {};
+<Secret/sh.helm.release.v1.stream-etcd.v2>.kind = "Secret";
+<Secret/sh.helm.release.v1.stream-etcd.v2>.metadata = {};
+<Secret/sh.helm.release.v1.stream-etcd.v2>.metadata.labels = {};
+<Secret/sh.helm.release.v1.stream-etcd.v2>.metadata.labels.name = "stream-etcd";
+<Secret/sh.helm.release.v1.stream-etcd.v2>.metadata.labels.owner = "helm";
+<Secret/sh.helm.release.v1.stream-etcd.v2>.metadata.labels.version = "2";
+<Secret/sh.helm.release.v1.stream-etcd.v2>.metadata.name = "sh.helm.release.v1.stream-etcd.v2";
+<Secret/sh.helm.release.v1.stream-etcd.v2>.metadata.namespace = "stream";
+<Secret/sh.helm.release.v1.stream-etcd.v2>.type = "helm.sh/release.v1";
@@ -3910 +3922 @@
-<StatefulSet/stream-etcd>.spec.template.spec.containers[0].env[21].value = "new";
+<StatefulSet/stream-etcd>.spec.template.spec.containers[0].env[21].value = "existing";
@@ -4150 +4162 @@
-<StatefulSet/stream-storage-writer-reader>.spec.template.spec.containers[0].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<StatefulSet/stream-storage-writer-reader>.spec.template.spec.containers[0].image = "docker.io/keboola/stream-api:74b537f-1721220054";
@@ -4226 +4238 @@
-<StatefulSet/stream-storage-writer-reader>.spec.template.spec.containers[1].image = "docker.io/keboola/stream-api:b6561fb-1721219656";
+<StatefulSet/stream-storage-writer-reader>.spec.template.spec.containers[1].image = "docker.io/keboola/stream-api:74b537f-1721220054";


(see artifacts in the Github Action for more information)

@Matovidlo Matovidlo force-pushed the mv-fixes-source-writer-assignment branch from 74b537f to db5342b Compare July 17, 2024 12:51
@Matovidlo Matovidlo mentioned this pull request Jul 17, 2024
Merged
@Matovidlo Matovidlo changed the title Mv fixes source writer assignment fix: Reduce cognitive complexity of functions in storage level writer. Jul 18, 2024
Base automatically changed from michaljurecko-PSGO-591-source-wirter-assignment to main July 18, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jachym-tousek-keboola jachym-tousek-keboola Awaiting requested review from jachym-tousek-keboola jachym-tousek-keboola will be requested when the pull request is marked ready for review jachym-tousek-keboola is a code owner

@hosekpeter hosekpeter Awaiting requested review from hosekpeter hosekpeter will be requested when the pull request is marked ready for review hosekpeter is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Stream API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Matovidlo