fix: Preserve state on rollback #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jachym-tousek-keboola
requested review from
Matovidlo and
hosekpeter
as code owners
jachym-tousek-keboola
changed the title
jachym-tousek-keboola
changed the base branch from
main
to
jt-psgo-916-undelete
jachym-tousek-keboola
force-pushed
the
jt-psgo-918-rollback
branch
2 times, most recently
from
a561c2d to
b384483
Compare
jachym-tousek-keboola
force-pushed
the
jt-psgo-916-undelete
branch
from
fc8d147 to
5a1d0f1
Compare
jachym-tousek-keboola
force-pushed
the
jt-psgo-918-rollback
branch
from
b384483 to
58a8908
Compare
There was a problem hiding this comment.
Unrelated test fix. This e2e test was randomly failing.
test: https://github.com/keboola/keboola-as-code/tree/992fef0c1c99d4677c4c1ae945653f176e7d6f65/test/templates/api/projects/instance-delete
failure: https://github.com/keboola/keboola-as-code/actions/runs/11629666014/job/32387060642?pr=2131
After checking it I noticed that there are two directories prefixed with 005. The list-instances should be 008 so that it's executed after both polls are finished.
internal/pkg/service/stream/definition/repository/source/source_version.go
Show resolved
Hide resolved
hosekpeter
approved these changes
Nov 1, 2024
internal/pkg/service/stream/definition/repository/sink/sink_enable_test.go
Show resolved
Hide resolved
Matovidlo
reviewed
Nov 1, 2024
internal/pkg/service/stream/definition/repository/source/source_version.go
Show resolved
Hide resolved
Matovidlo
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://keboola.atlassian.net/browse/PSGO-918
Changes: