Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ld_classic is deprecated #2135

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: ld_classic is deprecated #2135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-e2e-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:

# Prevent linker warnings on macOs (https://github.com/golang/go/issues/61229#issuecomment-1988965927)
if [ "$RUNNER_OS" == "macOS" ]; then
export GOFLAGS="-ldflags=-extldflags=-Wl,-ld_classic"
export GOFLAGS="-ldflags=-linkmode=internal"
fi

# Build binary for test without external inputs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
run: |
# Prevent linker warnings on macOs (https://github.com/golang/go/issues/61229#issuecomment-1988965927)
if [ "$RUNNER_OS" == "macOS" ]; then
export GOFLAGS="-ldflags=-extldflags=-Wl,-ld_classic"
export GOFLAGS="-ldflags=-linkmode=internal"
fi

# Prevent testing unnecessary code for particular release
Expand Down
Loading