feat: Preview endpoint #2162
Merged
feat: Preview endpoint #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hosekpeter
force-pushed
the
petr-hosek-PSGO-895
branch
2 times, most recently
from
6519711 to
834b9b6
Compare
hosekpeter
force-pushed
the
petr-hosek-PSGO-895
branch
from
ec786a5 to
bc9a56d
Compare
hosekpeter
commented
Nov 28, 2024
internal/pkg/template/mappers.go
Outdated
Comment on lines
76
to
85
| if c, ok := ctx.(previewContext); ok { | ||
| if _, isUseContext := ctx.(useContext); !isUseContext { | ||
| mappers = append(mappers, metadata.NewMapperWithoutInstanceID( | ||
| s, | ||
| c.TemplateRef(), | ||
| c.ObjectIds(), | ||
| c.InputsUsage(), | ||
| )) | ||
| } | ||
| } |
There was a problem hiding this comment.
The logic for adding metadata mappers in the template preview operation was previously duplicated. This update refactors the code to ensure that the metadata. NewMapperWithoutInstanceID mapper is added only once for the template preview operation.
hosekpeter
requested review from
jachym-tousek-keboola and
Matovidlo
as code owners
Matovidlo
requested changes
Nov 28, 2024
...ies/template-preview/repository/my-template/v1/src/app/keboola.data-apps/my-app/meta.jsonnet
Outdated
Show resolved
Hide resolved
hosekpeter
force-pushed
the
petr-hosek-PSGO-895
branch
from
94a2f01 to
8ac39ba
Compare
Matovidlo
requested changes
Nov 29, 2024
...templates/api/repositories/template-preview-unknown-variable/002-poll/expected-response.json
Show resolved
Hide resolved
hosekpeter
force-pushed
the
petr-hosek-PSGO-895
branch
from
9f49095 to
07e5191
Compare
Matovidlo
reviewed
Nov 29, 2024
...templates/api/repositories/template-preview-unknown-variable/002-poll/expected-response.json
Show resolved
Hide resolved
Matovidlo
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: PSGO-895
Changes: