Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Keboola bridge #2163

Merged
merged 3 commits into from
Dec 2, 2024
Merged

refactor: Keboola bridge #2163

merged 3 commits into from
Dec 2, 2024

Conversation

jachym-tousek-keboola
Copy link
Contributor

@jachym-tousek-keboola jachym-tousek-keboola commented Nov 28, 2024 •
edited
Loading

  1. Apparently we forgot to put the FileKey to File object. All other objects saved to etcd have their own key identifier so it should be here as well. We don't need a migration, the old files where it's nil will be deleted by cleanup after they're processed. Then we can make FileKey mandatory and remove SinkKey since FileKey contains it.
  2. JobKey was left outside of keboola bridge by accident so I moved it.

@jachym-tousek-keboola jachym-tousek-keboola changed the title fix: Add missing FileKey refactor: Keboola bridge adjustments Nov 28, 2024
@jachym-tousek-keboola jachym-tousek-keboola marked this pull request as ready for review November 28, 2024 15:00
@jachym-tousek-keboola jachym-tousek-keboola changed the title refactor: Keboola bridge adjustments refactor: Keboola bridge Nov 28, 2024
hosekpeter
hosekpeter approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@hosekpeter hosekpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jachym-tousek-keboola jachym-tousek-keboola merged commit abcd567 into main Dec 2, 2024
12 checks passed
@jachym-tousek-keboola jachym-tousek-keboola deleted the jt-missing-file-key branch December 2, 2024 08:13
@jachym-tousek-keboola jachym-tousek-keboola restored the jt-missing-file-key branch December 2, 2024 08:13
@jachym-tousek-keboola jachym-tousek-keboola deleted the jt-missing-file-key branch December 2, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hosekpeter hosekpeter hosekpeter approved these changes

@Matovidlo Matovidlo Matovidlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jachym-tousek-keboola @Matovidlo @hosekpeter