feat: Add toxiproxy stream test #2175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matovidlo
force-pushed
the
feat-add-toxiproxy-stream-test
branch
10 times, most recently
from
be1bb48 to
8ca2718
Compare
Matovidlo
requested review from
jachym-tousek-keboola and
hosekpeter
as code owners
Matovidlo
commented
Dec 13, 2024
| @@ -151,6 +151,7 @@ func (c *ClientConnection) Close(ctx context.Context) error { | |||
|
|
|||
| func (c *ClientConnection) dialLoop(ctx context.Context, initDone chan error) { | |||
| b := newClientConnBackoff() | |||
| b.InitialInterval = 100 * time.Millisecond | |||
There was a problem hiding this comment.
Due to toxiproxy we have now higher latency and this often failed locally.
|
|
||
| ts := setup(t) | ||
| client := toxiproxyClient.NewClient("localhost:8474") | ||
| proxy, err := client.CreateProxy("source1", ts.sourceURL1[7:len(ts.sourceURL1)-1], ts.sourceURL1[7:]) |
There was a problem hiding this comment.
If the source url is localhost:12345 i want to create new proxy on host:port localhost:1234.
It can be adjusted to randomized port
Matovidlo
force-pushed
the
feat-add-toxiproxy-stream-test
branch
from
8ca2718 to
aad00b2
Compare
The ETCD connection cannot be established
Matovidlo
force-pushed
the
feat-add-toxiproxy-stream-test
branch
from
aad00b2 to
86b6f90
Compare
| func TestKeboolaBridgeWorkflow(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| func TestKeboolaBridgeWorkflow(t *testing.T) { // nolint: paralleltest |
There was a problem hiding this comment.
why no parallel?
There was a problem hiding this comment.
There is issue in etcd connection when being in parallel. Looks like we have some issue in the test suite. I will create subsequent tasks to dig into the issue. Simply adding parallel will make the test fail in CI for sure. The result locally varies.
There was a problem hiding this comment.
jachym-tousek-keboola
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: PSGO-108
Changes:
We still receive error with no space left on device in tagged GH action workflows
