Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix templates tests #2176

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix: Fix templates tests #2176

merged 2 commits into from
Dec 13, 2024

Conversation

hosekpeter
Copy link
Contributor

@hosekpeter hosekpeter commented Dec 9, 2024

Jira: PSGO-898

Changes:


After running a local test we got this. We can see there, that dynamic IDs don't match. Therefore I am ignoring this IDs for tests.
image

@hosekpeter hosekpeter marked this pull request as ready for review December 10, 2024 09:08
Copy link
Contributor

@Matovidlo Matovidlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add test what actually changed? I see normalization of string but I don't see the tests associated with this change

@hosekpeter hosekpeter marked this pull request as draft December 10, 2024 12:46
@hosekpeter hosekpeter force-pushed the petr-hosek-PSGO-898 branch 2 times, most recently from 8e0d854 to aba507c Compare December 12, 2024 14:36
@hosekpeter hosekpeter marked this pull request as ready for review December 12, 2024 19:04
@hosekpeter hosekpeter requested a review from Matovidlo December 12, 2024 19:04
Copy link
Contributor

@Matovidlo Matovidlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hosekpeter hosekpeter merged commit ff18572 into main Dec 13, 2024
12 checks passed
@hosekpeter hosekpeter deleted the petr-hosek-PSGO-898 branch December 13, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants