fix: Name and tag of race image in docker repository should be different than production one #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not override production image.
Matovidlo
requested review from
jachym-tousek-keboola and
hosekpeter
as code owners
Matovidlo
changed the title
|
toto uz teda nebudes potrebovat nasadit ci? https://keboolaglobal.slack.com/archives/C055K9CRFDX/p1733849063356059?thread_ts=1733834074.491109&cid=C055K9CRFDX |
|
@kacurez neviem ci to pomoze ci nie, niekde sa zvysil memory consumption a neviem teda ci je to imagom (skor nie) alebo kodom. |
kacurez
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
nie som si isty ci to pomozme ale mozme skusit, je vidiet ze sa nasadil image s tym race
ale pod prod tagom https://keboolaglobal.slack.com/archives/C055K9CRFDX/p1733913074422449?thread_ts=1733834074.491109&cid=C055K9CRFDX
wokoman
requested changes
Dec 11, 2024
Does not influence the `registry/repository` at all and overrides existing image
Matovidlo
force-pushed
the
fix-race-image-name-ecr-docker-repository
branch
from
fd0aca5 to
cbb010d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: