Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT-807 php8 #86

Merged
merged 15 commits into from
Feb 3, 2023
Merged

CT-807 php8 #86

merged 15 commits into from
Feb 3, 2023

Conversation

zajca
Copy link
Member

@zajca zajca commented Feb 1, 2023 •
edited
Loading

BC break

  • removed legacy mode from redshift
  • drop support for php <7.4

@zajca zajca changed the title Ct 807 php8 CT-807 php8 Feb 2, 2023
@zajca zajca mentioned this pull request Feb 2, 2023
Merged
1 task
@zajca zajca marked this pull request as ready for review February 2, 2023 21:07
@zajca zajca requested review from a team, romanbracinik and martinjunger and removed request for a team and romanbracinik February 2, 2023 21:08
@martinjunger
Copy link
Contributor

👁️

@martinjunger martinjunger mentioned this pull request Feb 3, 2023
Closed
martinjunger
martinjunger suggested changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@martinjunger martinjunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, jen chybejici unit testy a par drobnosti

@zajca zajca requested a review from martinjunger February 3, 2023 14:19
martinjunger
martinjunger approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@martinjunger martinjunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@zajca zajca merged commit 0f2b1d4 into master Feb 3, 2023
@zajca zajca deleted the CT-807-php8 branch February 3, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjunger martinjunger martinjunger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zajca @martinjunger