[output-mapping] Split TableStructureValidator #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrajodas
force-pushed
the
PST-1775-ondra
branch
from
f30407d to
2081605
Compare
ondrajodas
commented
Dec 16, 2024
Comment on lines
-33
to
-38
| if (!$this->hasNewNativeTypeFeature) { | ||
| return $tableChangesStore; | ||
| } | ||
| if (!$schemaColumns) { | ||
| return $tableChangesStore; | ||
| } |
There was a problem hiding this comment.
tyhle podmínky jsou tady zbytečně, tak jsem je do přepsanýho kódu vůbec nedával
ChangesStore totiž vstupuje jen do StoragePreparer a tam je podmínka stejná, takže tady to řešit nemusíme
ondrajodas
force-pushed
the
PST-1775-ondra
branch
from
2081605 to
567e297
Compare
ErikZigo
approved these changes
Dec 20, 2024
| } | ||
| throw new InvalidOutputException($e->getMessage(), $e->getCode(), $e); | ||
| if ($this->table['isTyped'] === true) { | ||
| throw new InvalidOutputException('Table is typed.'); |
There was a problem hiding this comment.
V té chybové hlášce by mělo být jméno nebo ID té tabulky.
| public function validate(?array $schemaColumns): TableChangesStore | ||
| { | ||
| if ($this->table['isTyped'] === false) { | ||
| throw new InvalidOutputException('Table is not typed.'); |
There was a problem hiding this comment.
V té chybové hlášce by mělo být jméno nebo ID té tabulky.
|
upravil jsem ty error messages a vypnul jsem ještě Synapse testy |
ondrajodas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://keboola.atlassian.net/browse/PST-1775