Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOX-78 tokens #1085

Merged
merged 3 commits into from
Jun 20, 2023
Merged

SOX-78 tokens #1085

merged 3 commits into from
Jun 20, 2023

Conversation

zajca
Copy link
Member

@zajca zajca commented Jun 19, 2023

Jira: SOX-78
KBC: https://github.com/keboola/connection/pull/4454

Before asking for review make sure that:

Checklist

  • New client method(s) has tests
  • Apiary file is updated

Release

  • I gave the PR a proper label:
    • major (BC break)
    • minor (new feature)
    • patch (backwards compatible fix)
    • no release (just test changes)

@zajca zajca added the no release just test changes label Jun 19, 2023
@zajca zajca requested a review from romanbracinik June 19, 2023 12:43
@zajca zajca changed the base branch from master to zajca-sox-73-2 June 19, 2023 12:53
romanbracinik
romanbracinik approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@romanbracinik romanbracinik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from zajca-sox-73-2 to master June 20, 2023 07:09
@zajca zajca merged commit 1ebf8e0 into master Jun 20, 2023
@zajca zajca deleted the zajca-sox-78 branch June 20, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanbracinik romanbracinik romanbracinik approved these changes

Assignees
No one assigned
Labels
no release just test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zajca @romanbracinik