Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce AWS library size #992

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reduce AWS library size #992

wants to merge 1 commit into from

Conversation

tomasfejfar
Copy link
Contributor

Jira: N/A
KBC: N/A

Before asking for review make sure that:

Checklist

  • New client method(s) has tests
  • Apiary file is updated

Release

  • I gave the PR a proper label:
    • major (BC break)
    • minor (new feature)
    • patch (backwards compatible fix)
    • no release (just test changes)

@tomasfejfar tomasfejfar added the no release just test changes label Jan 31, 2023
@tomasfejfar
Copy link
Contributor Author

Prošel mi phpstan a test na založení tabulky, tak předpokládám, že je to OK :)

@tomasfejfar tomasfejfar requested review from a team and romanbracinik and removed request for a team January 31, 2023 09:27
},
"extra": {
"aws/aws-sdk-php": [
"S3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rekl bych, ze tam nemusi to S3 byt, viz ten priklad a note na konci

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mne to failuje ked tam nic nieje

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, ja to nezkousel, jen me to zaujalo v dokumentaci 🤷

},
"extra": {
"aws/aws-sdk-php": [
"S3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mne to failuje ked tam nic nieje

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no release just test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants