git_status: Fix non-null arithmetic exit status #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from post-increment to pre-increment in the counter implementation in order to avoid the behaviour where
(( X++ ))
returns 1 ifX
evaluates to0
, which is interpreted as a failure exitstatus, in turn causing the whole script to terminate prematurely.
Note that, for
X
non-negative,(( ++X ))
never evaluates to0
, avoiding the unintended behaviour.Reference: