Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown flag --metrics-port when enabling prometheus on the operator #342

Closed
nextrevision opened this issue Dec 9, 2022 · 1 comment · Fixed by #343
Closed

Unknown flag --metrics-port when enabling prometheus on the operator #342

nextrevision opened this issue Dec 9, 2022 · 1 comment · Fixed by #343
Labels
bug Something isn't working

Comments

@nextrevision
Copy link

Expected Behavior

Enabling scraping on the prometheus operator should create a PodMonitor.

prometheus:
  operator:
    enabled: true
    podMonitor:
      enabled: true

Actual Behavior

The pod fails to start with the following error:

Usage of /keda:
      --disable-compression                   Disable response compression for k8s restAPI in client-go.  (default true)
      --health-probe-bind-address string      The address the probe endpoint binds to. (default ":8081")
      --kube-api-burst int                    Set the burst for throttling requests sent to the apiserver (default 30)
      --kube-api-qps float32                  Set the QPS rate for throttling requests sent to the apiserver (default 20)
      --kubeconfig string                     Paths to a kubeconfig. Only required if out-of-cluster.
      --leader-elect                          Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.
      --metrics-bind-address string           The address the metric endpoint binds to. (default ":8080")
      --metrics-service-bind-address string   The address the gRPRC Metrics Service endpoint binds to. (default ":9666")
      --zap-devel                             Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)
      --zap-encoder encoder                   Zap log encoding (one of 'json' or 'console') (default )
      --zap-log-level level                   Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity (default )
      --zap-stacktrace-level level            Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
      --zap-time-encoding time-encoding       Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'. (default )
unknown flag: --metrics-port

The metrics port in the template: https://github.com/kedacore/charts/blob/main/keda/templates/12-keda-deployment.yaml#L75

Steps to Reproduce the Problem

  1. Enable prometheus scraping on the operator via values.
  2. Deploy latest chart.

Specifications

  • KEDA Version: 2.9.0
  • Platform & Version: EKS
  • Kubernetes Version: 1.23
  • Scaler(s): N/A
@nextrevision nextrevision added the bug Something isn't working label Dec 9, 2022
@zroubalik
Copy link
Member

Thanks for reporting, that's definitely a bug, it should be --metrics-bind-address :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants