Added missing attributes and improvements to deployment yaml file and… #14
Conversation
… normalized yaml file names - Added features to deployment: nodeSelector, securityContext, tolerations, affinity
robece
requested review from
ahmelsayed,
jeffhollan and
tomkerkhove
as code owners
| - name: {{ .Values.operatorName }}-metrics-apiserver | ||
| image: {{ .Values.image.metricsAdapter }} | ||
| image: "{{ .Values.image.metricsAdapter }}:{{ .Chart.AppVersion }}" |
There was a problem hiding this comment.
Ok for you if we add this @ahmelsayed? It's fine for me.
There was a problem hiding this comment.
I'd prefer if there is a way to override the full image name because it enables using helm for deploying a custom keda. like this
|
LGTM but prefer to have @ahmelsayed his sign-off as well |
|
Let's merge #16 first so we have the CI validation as well. |
|
Thanks @robece. I think we need to merge #10 first which will cause a conflict with your changes, but #10 is part of kedacore/keda#506 which I merged yesterday in the other repo but missed the one here. Would you mind merging the changes in master again? sorry about that |
|
No worries, please let me know once the first merge is done and I can do the second merge with my changes today. |
|
Closing since #17 is now open |
… normalized yaml file names