Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multi-tenant scaler and interceptor in the HTTP add-on #169

Merged
merged 33 commits into from
Nov 9, 2021
Merged

feat: multi-tenant scaler and interceptor in the HTTP add-on #169

merged 33 commits into from
Nov 9, 2021

Conversation

arschles
Copy link
Collaborator

@arschles arschles commented Jul 1, 2021 •
edited
Loading

These are the chart changes to go along with kedacore/http-add-on#206

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Expose ports on the interceptor and build svc-interceptor-admin.yaml and svc-interceptor-proxy.yaml
  • Expose ports on the operator and build svc-operator-admin.yaml
  • Test chart install with new images built from Multi-tenant interceptor and scaler http-add-on#206
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
  • README is updated with new configuration values (if applicable)

Fixes #

arschles added 14 commits July 1, 2021 16:18
@arschles
multi-tenant scaler and interceptor in the HTTP add-on
702729e 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
configuring the operator with the admin port and exposing the contain…
b9382cc 
…er port appropriately

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
adding the various services
328c0d2 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
adding more required runtime configs
3140346 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
quoting the port number
17b0f2f 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
adding named container ports to the interceptor
3c5b57b 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
using proper selectors and named ports
ee0aab1 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
fixing service and port env vars
f30d716 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
updating the CRD
0ea1c51 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
proper interceptor scaler service
e97bdaa 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
adding configs to operator
e26d02f 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
adding container ports to scaler
24e8465 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
targeting the right scaler deployment port
e74860e 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
adding scaledobject for interceptor
85d9827 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles arschles mentioned this pull request Jul 29, 2021
Merged
29 tasks
arschles added 3 commits July 29, 2021 15:29
@arschles
finishing comment in interceptor ScaledObject
869812c 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding polling interval to interceptor scaled object
dcf0794 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
removing unnecessary configuration parameters
9026a80 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles arschles mentioned this pull request Aug 19, 2021
Closed
@arschles
adding configuration for deployment polling
11cbcff 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding config params for the interceptor's proxy
cf79560 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
respecting crds.install config
7c8a577 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding routing table config map
512b7ef 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding a default pending requests for the scaler
f767dd9 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
matching deployment cache polling interval to the default
da9be3d 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
removing commented env vars
0ac99c7 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
removing placeholder data
dbd7413 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
Small restructuring of values.yaml per @tomkerkhove
9a86221 
Also adding lots of comments to it

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
quoting a config integer
738ba9c 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
adding routing table config map (empty) data
b392fcf 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles arschles changed the title Multi-tenant scaler and interceptor in the HTTP add-on feat: multi-tenant scaler and interceptor in the HTTP add-on Oct 28, 2021
@arschles
adding config values to the HTTP Addon README
e72ee92 
Signed-off-by: Aaron <aaron@ecomaz.net>
@arschles
bumping the release numbers
aada9cf 
Signed-off-by: Aaron <aaron@ecomaz.net>
@arschles
packaging new release
f0981fb 
Signed-off-by: Aaron <aaron@ecomaz.net>
@arschles
Merge branch 'master' of https://github.com/kedacore/charts into http…
b440cc4 
…-add-on-global-components

Signed-off-by: Aaron <aaron@ecomaz.net>
@arschles
fixing lint error
4354bee 
Signed-off-by: Aaron <aaron@ecomaz.net>
@arschles arschles marked this pull request as ready for review November 2, 2021 19:48
@arschles
Copy link
Collaborator Author

arschles commented Nov 2, 2021

@tomkerkhove this is ready for merge! The HTTP Addon is ready to release v0.2.0, so when this is merge I'll hit the button over there

@tomkerkhove
Copy link
Member

Let's do this!

tomkerkhove
tomkerkhove approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge when it has been shipped

@arschles
Copy link
Collaborator Author

arschles commented Nov 3, 2021

@tomkerkhove I don't seem to have permission to merge. Looked through my email to see if there are any invites for GitHub but don't see anything. My GitHub notifications are a bit of a nightmare, so I may have missed something.

@tomkerkhove
Copy link
Member

PTAL

@arschles
Copy link
Collaborator Author

arschles commented Nov 4, 2021

@tomkerkhove got the permissions now, thank you!

I'll merge this on Monday (would like to avoid a Friday release) and do the release shortly thereafter.

@arschles arschles merged commit f9e25e6 into kedacore:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@jeffhollan jeffhollan Awaiting requested review from jeffhollan

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arschles @tomkerkhove