Fix indentation of ServiceAccount annotations #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorTurFer
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
LGTM! Could you sign your commit? (It's required)
Thanks for the contribution!
|
@bmalinconico Would you have some time to fix DCO or are you a bit occupied at the moment? |
2 tasks
Signed-off-by: Brian Malinconico <bmalinconico@terminus.com>
bmalinconico
force-pushed
the
bmalinconico-patch-1
branch
from
bc54c57 to
e491a6e
Compare
|
@tomkerkhove @JorTurFer signed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indentation of this line is incorrect and setting a value for the service account annotations produces an invalid chart. Note that these values should be the same level as the "label" above.
Checklist
Fixes #