chore: Introduce Azure Workload Identity in CI matrix #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce Azure Workload Identity in CI matrix to ensure it renders correctly Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
|
CI is failing, which is expected. Time to merge #264 |
|
I think the CI will fail even after #264 is merged. > helm install keda ./keda --set podIdentity.azureWorkload.enabled=true
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: error validating "": error validating data: [unknown object type "nil" in ServiceAccount.metadata.annotations.azure.workload.identity/client-id, unknown object type "nil" in ServiceAccount.metadata.annotations.azure.workload.identity/tenant-id]This is from local when I tried. It works when specifying the client and tenant ids. Which is good I would say, it prevents the user from enabling workload identity without specifying these values. I think you would need to add some dummy client and tenant ids. |
That is intended indeed, I want to verify it first. |
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
tomkerkhove
commented
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Azure Workload Identity in CI matrix to ensure it renders correctly
Checklist
Relates to kedacore/keda#2487
Relates to #263