feat(keda): affinities for keda and metrics server #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorTurFer
requested changes
Jul 28, 2022
There was a problem hiding this comment.
This is a breaking change and we avoid them before next major version release. I know that there are several inconsistencies on the chart, but even that we still prefer to not introduce breaking changes. Could you introduce your changes without breaking backward compatibility?
Signed-off-by: GitHub <noreply@github.com>
tomkerkhove
approved these changes
Jul 28, 2022
JorTurFer
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zadkiel Aharonian hello@zadkiel.fr
Add ability to specify different affinities for keda and metrics server
Checklist
Fixes #