Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide support for image pull secret in HTTP add-on #296

Merged
merged 5 commits into from
Aug 2, 2022
Merged

feat: Provide support for image pull secret in HTTP add-on #296

merged 5 commits into from
Aug 2, 2022

Conversation

kvandenhoute
Copy link
Contributor

@kvandenhoute kvandenhoute commented Aug 2, 2022 •
edited by tomkerkhove
Loading

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
  • README is updated with new configuration values (if applicable)

Fixes

  • Added the option to specify imagePullSecrets

@kvandenhoute kvandenhoute requested a review from a team as a code owner August 2, 2022 07:47
tomkerkhove
tomkerkhove approved these changes Aug 2, 2022
View reviewed changes
http-add-on/README.md Outdated Show resolved Hide resolved
@tomkerkhove tomkerkhove changed the title Feature/add imagepullsecrets feat: Provide support for image pull secret in HTTP add-on Aug 2, 2022
kvandenhoute added 2 commits August 2, 2022 09:58
Add imagepullsecrets to the deployments
96f524b 
Signed-off-by: kvandenhoute <kvandenhoute@sofico.be>
Bump chart version + update README
60b94e8 
Signed-off-by: kvandenhoute <kvandenhoute@sofico.be>
@kvandenhoute kvandenhoute force-pushed the feature/add_imagepullsecrets branch from c0538b8 to 60b94e8 Compare August 2, 2022 07:59
kvandenhoute added 3 commits August 2, 2022 10:00
Indent
4c1f7b5 
Signed-off-by: kvandenhoute <kvandenhoute@sofico.be>
Switch indent to nindent
b3a4f36 
Signed-off-by: kvandenhoute <kvandenhoute@sofico.be>
Some more indents
327a162 
Signed-off-by: kvandenhoute <kvandenhoute@sofico.be>
@tomkerkhove tomkerkhove merged commit 2e5e2c9 into kedacore:main Aug 2, 2022
@tomkerkhove
Copy link
Member

Thanks a ton!

@tomkerkhove tomkerkhove added this to the KEDA HTTP Add-On vNext milestone Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
KEDA HTTP Add-On vNext
Development

Successfully merging this pull request may close these issues.
2 participants
@kvandenhoute @tomkerkhove