-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add seccompProfile #307
Conversation
a99118b
to
ed2753c
Compare
NOTE: seccompProfile is only supported in Kubernetes 1.19+ This is causing the 1.17 and 1.18 tests to fail. |
It is best to use Helm operators to check if the feature is available to avoid this, can you take a look at this? This is typically done through the API version |
@tomkerkhove wrote:
I think the options are:
|
I think that's the best approach |
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
ed2753c
to
132aba6
Compare
@tomkerkhove PTAL Since seccompProfile requires Kubernetes 1.19+ (otherwise validation fails), I think this is the best that should be done until the minimum version is raised from 1.17 to 1.19. While it should be possible to finagle the values here, it is not possible in keda/config (kedacore/keda#3562) and I think it's better to keep the two in sync. |
Let's make sure the change is being applied because nobody will notice the comment. As per https://github.com/kedacore/governance/blob/main/SUPPORT.md#kubernetes-support I'll enforce Kubernetes v1.20. |
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
@tomkerkhove PTAL I restored the seccompProfile changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Add/update securityContext configs:
Checklist
Fixes #306
Fixes #301