Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for AWS IRSA in helm chart #319

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Added support for AWS IRSA in helm chart #319

merged 3 commits into from
Oct 3, 2022

Conversation

StevenJDH
Copy link
Contributor

Signed-off-by: Steven Jenkins De Haro 20492442+StevenJDH@users.noreply.github.com

Adds support for AWS IAM Roles for Service Accounts (IRSA) in the helm chart to the KEDA service account. For example, if podIdentity.irsa.enabled is set true along with the needed config, the below will be rendered:

apiVersion: v1
kind: ServiceAccount
...
  annotations:
    eks.amazonaws.com/audience: "sts.amazonaws.com"
    eks.amazonaws.com/role-arn: "arn:aws:iam::000000000000:role/example-irsa-role"
    eks.amazonaws.com/sts-regional-endpoints: "true"
    eks.amazonaws.com/token-expiration: "3600"
...

Checklist

  • [ X] Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • [ X] A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
  • [X ] README is updated with new configuration values (if applicable)

Fixes #233

@StevenJDH StevenJDH requested a review from a team as a code owner September 30, 2022 02:09
Signed-off-by: Steven Jenkins De Haro <20492442+StevenJDH@users.noreply.github.com>
Signed-off-by: Steven Jenkins De Haro <20492442+StevenJDH@users.noreply.github.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we'd need to rename the variables

keda/README.md Outdated Show resolved Hide resolved
Signed-off-by: Steven Jenkins De Haro <20492442+StevenJDH@users.noreply.github.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tomkerkhove tomkerkhove merged commit 0467687 into kedacore:main Oct 3, 2022
@StevenJDH StevenJDH deleted the feature/add_support_for_irsa_helm_chart branch October 3, 2022 09:16
@ivanmarquescepsa
Copy link

hi, i would need this feature, do you have an estimate of when will it be released?

Thanks!

@hlastraspfx
Copy link

Same question: when will it be released? Any news?

@JorTurFer
Copy link
Member

Next KEDA release will be around Dec 8th, and it includes the chart. You can check the release dates here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helm chart option for EKS IRSA account
5 participants