Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Standardise to LF line endings #332

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Conversation

blottn
Copy link
Contributor

@blottn blottn commented Nov 23, 2022

Small cleanup on file mode and line endings

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
  • README is updated with new configuration values (if applicable)

Fixes #

  • Standardise to LF line endings
  • Fix file mode for 13-keda-poddisruptionbudget.yaml which had executable mode

@blottn blottn requested a review from a team as a code owner November 23, 2022 15:26
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution ❤️
There is another PR adding PDBs in the CI, I'd like to have it merged to check that this works properly (because there is a change there indeed)

@tomkerkhove tomkerkhove changed the title File fixes chore: Standardise to LF line endings Nov 24, 2022
Signed-off-by: Nicholas Blott <blottn@tcd.ie>
Signed-off-by: Nicholas Blott <blottn@tcd.ie>
@tomkerkhove tomkerkhove merged commit 1edb5cd into kedacore:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants