Fixed affinity and tolerations helm chart issue #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viperKiran
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
* Provide capability to specify annotations in Helm chart Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Use podAnnotations for metricsAdapter / keda Signed-off-by: kiran <kiran.sundaravarathan@paytm.com>
Signed-off-by: kiran <kiran.sundaravarathan@paytm.com>
* Add priorityClassName to pods specs Signed-off-by: Amir Schwartz <amschwar@microsoft.com> * Increment chart version Signed-off-by: Amir Schwartz <amschwar@microsoft.com> Co-authored-by: Amir Schwartz <amschwar@microsoft.com> Signed-off-by: kiran <kiran.sundaravarathan@paytm.com>
…ic-apiserver Signed-off-by: kiran <kiran.sundaravarathan@paytm.com>
Signed-off-by: kiran <kiran.sundaravarathan@paytm.com>
Signed-off-by: kiran <kiran.sundaravarathan@paytm.com>
|
Since it's shipping a new version it would be good to have @ahmelsayed his signoff as well |
|
Actually I would suggest not to ship a new version yet and waith for new release cycle |
|
Thanks, @tomkerkhove for approving this. I am wondering about the merge conflict since I don't have write access. Will maintainers take care of it? |
|
That's actually something you can fix by merging master in your branch and fixing the conflicts. Would you mind removing the changes that ship a new version as well please? |
added 2 commits
April 1, 2020 14:04
Signed-off-by: kiran <kiran.sundaravarathan@paytm.com>
|
@tomkerkhove Done as you wish. Let me know if you have any concerns. |
|
LGTM, thanks for the contribution @viperKiran! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found affinity and tolerations in deployments are indented wrongly and added Pod Disruption Budget template for keda and metrics.