Updating templates to remove blank annotations #486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the keda chart, I noticed that annotations can generate empty key's when no additional annotations are passed in e.g.
I am attempted to just alter the helm template logic to only create the annotation key should there be a value passed in. I have added a before and after yaml from running
helm template
locally. I carried out some local testing where I passed in a number of different values (i.e. not justAdditionalAnnotations
) and seemed ok to me.Checklist
Fixes #
Files for comparison:
beforeAfter.zip