Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pod monitor port name does not match deployment spec #602

Merged
merged 1 commit into from
Jan 28, 2024
Merged

fix: pod monitor port name does not match deployment spec #602

merged 1 commit into from
Jan 28, 2024

Conversation

pragmaticivan
Copy link
Contributor

@pragmaticivan pragmaticivan commented Jan 27, 2024 •
edited
Loading

PodMonitor port name is set as http but the deployment port name is set as metrics.

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #601

@pragmaticivan pragmaticivan requested a review from a team as a code owner January 27, 2024 17:40
@pragmaticivan
fix: pod monitor port name does not match deployment spec
28e86af 
Signed-off-by: Ivan Santos <301291+pragmaticivan@users.noreply.github.com>
@pragmaticivan pragmaticivan force-pushed the fix-podmonitor-port-name branch from 1218707 to 28e86af Compare January 27, 2024 17:41
@JorTurFer
Copy link
Member

Nice catch!

@JorTurFer JorTurFer enabled auto-merge (squash) January 28, 2024 17:55
@JorTurFer JorTurFer merged commit 395ea88 into kedacore:main Jan 28, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PodMonitor using incorrect port name
2 participants
@pragmaticivan @JorTurFer