Allow extra egress rules for the keda operator ciliumnetworkpolicy #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
add-extra-egress-to-cnps
branch
from
0051078 to
486bfc9
Compare
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
QuentinBisson
force-pushed
the
add-extra-egress-to-cnps
branch
from
486bfc9 to
5a53410
Compare
JorTurFer
approved these changes
Feb 23, 2024
|
Thanks for the improvement! |
1 task
QuentinBisson
added a commit
to giantswarm/keda-upstream
that referenced
this pull request
Jul 1, 2024
…edacore#610) Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to be able to add extra egress rules to the ciliumnetworkpolicy if for instance, the prometheus used to scale is outside the cluster as the current ciliumnetworkpolicy only allows egress to the cluster pods and the api-server
Checklist