Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a way to customize the 'managed-by' label #619

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jkremser
Copy link
Contributor

@jkremser jkremser commented Mar 26, 2024

By default this is a no-operation (so backward compatibility is guaranteed). If the .customManagedBy value is not empty, it will be used as a value for app.kubernetes.io/managed-by label. This is useful, when using this helm chart as a source for some other tools just for rendering the manifests, but not using the helm {install,upgrade,uninstall} or any other day-2 stuff.

helm template . --set customManagedBy=foo | grep managed-by | head -1
    app.kubernetes.io/managed-by: foo


helm template . | grep managed-by | head -1                                                                                                                                                           
    app.kubernetes.io/managed-by: Helm

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • [ ] A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified) N/A

@jkremser jkremser requested a review from a team as a code owner March 26, 2024 10:50
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

@JorTurFer JorTurFer merged commit 31cc43f into kedacore:main Mar 26, 2024
37 checks passed
@jkremser jkremser deleted the allow-custom-managed-by branch March 27, 2024 11:29
QuentinBisson pushed a commit to giantswarm/keda-upstream that referenced this pull request Jul 1, 2024
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants